fix(amazonq): Add code reference opt-in config to non-SSO requests #5551
Conversation
|
This pull request modifies files in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
erikayao93
changed the title
|
This pull request modifies a feature or fixes a bug, but it does not include a changelog entry. All pull requests that introduce new features or bug fixes must have a corresponding changelog item describing the changes. |
| export async function buildGenerateRecommendationRequest(editor: vscode.TextEditor): Promise<{ | ||
| export async function buildGenerateRecommendationRequest( | ||
| editor: vscode.TextEditor, | ||
| allowCodeWithReference: boolean |
There was a problem hiding this comment.
nit - align it with the API definition - allowRecommendationsWithReferences?
There was a problem hiding this comment.
I based it off of the same parameter in buildListRecommendationRequest here
|
|
Please note:
Is there a reason a changelog wasn't added? |
|
I didn't realize this pull request was still open, apologies. I'll reopen this pull request at a later time when I have some time to re-sync my fork and update the changelog. |
4 participants
Problem
Without an SSO connection, code suggestions may still have references even if they have opted out in their settings.
Solution
When generating a recommendation request, always provide the
isSuggestionsWithCodeReferencesEnabledflag from configuration. This will default tofalseif the config is not found.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.